-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: place updater in same directory as update.sh #3983
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3983 +/- ##
==========================================
+ Coverage 49.76% 54.48% +4.71%
==========================================
Files 409 390 -19
Lines 69157 48500 -20657
==========================================
- Hits 34419 26423 -7996
+ Misses 31014 19858 -11156
+ Partials 3724 2219 -1505
Continue to review full report at Codecov.
|
5a84ae0
to
5d4bfdf
Compare
5d4bfdf
to
75bc8b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the comment
46c45cd
to
23f00c3
Compare
1c0f980
to
bbe4216
Compare
bbe4216
to
bbd56bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't run this, but it looks good on the surface. We should augment the test cases with something like:
- Run on darwin
- Run on linux, with gpg and sha256sum
- Run on linux, with gpg and without sha256sum
- Run on linux, without gpg and with sha256sum
- Run on linux without gpg and without sha256sum
I've added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update; preserving behavior is nice. Thinking about how we want to communicate this is a good idea too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I updated Sandbox to use one of the earlier drafts, I didn't realize the checksum/verify additions were coming.
Summary
Fixes #2581
While downloading and installing the
updater
, the commands were not specific about which directories to download and unarchive. Because of this, ifupdate.sh
was in$PATH
and was executed from a different directory, theupdater
archive would be installed in the$PWD
causing the script to not function as expected (download remaining tools), and would not error out.This solves that by creating a temporary directory and modifying the commands around installing the
updater
more explicit to make sure thatupdater
is in the same directory asupdate.sh
.This also adds a
-verify
command line flag (defaults tofalse
). If set,update.sh
will check if GPG and checksum validation is possible on linux systems, if so, the signature, public key, and checksum file will be downloaded and used to verify the updater archive.Test Plan
Can use this test script or the one referenced in #2581