Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StateProofs: fix GetProof endpoint response #3985

Merged
merged 1 commit into from
May 26, 2022
Merged

StateProofs: fix GetProof endpoint response #3985

merged 1 commit into from
May 26, 2022

Conversation

Aharonee
Copy link
Contributor

@Aharonee Aharonee commented May 15, 2022 •
edited by cce
Loading

@Aharonee Aharonee requested review from id-ms and cce May 15, 2022 15:14
@Aharonee Aharonee mentioned this pull request May 15, 2022
Merged
@Aharonee Aharonee changed the title Stateproofs: fix GetProof endpoint response StateProofs: fix GetProof endpoint response May 15, 2022
@codecov
Copy link

codecov bot commented May 15, 2022 •
edited
Loading

Codecov Report

Merging #3985 (486435e) into master (dd703da) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3985      +/-   ##
==========================================
+ Coverage   49.79%   49.80%   +0.01%     
==========================================
  Files         409      409              
  Lines       69157    69158       +1     
==========================================
+ Hits        34437    34446       +9     
+ Misses      31003    30996       -7     
+ Partials     3717     3716       -1
Impacted Files Coverage Δ
daemon/algod/api/server/v2/handlers.go 0.00% <0.00%> (ø)
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
ledger/tracker.go 75.32% <0.00%> (+2.16%) ⬆️
network/wsPeer.go 68.33% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd703da...486435e. Read the comment docs.

id-ms
id-ms approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@id-ms id-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winder winder merged commit a3003ec into algorand:master May 26, 2022
cce
cce reviewed May 26, 2022
View reviewed changes
Copy link
Contributor

@cce cce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

This was referenced May 27, 2022
Closed
Merged
@Algo-devops-service Algo-devops-service mentioned this pull request Jun 3, 2022
Merged
This was referenced Jun 8, 2022
Merged
Merged
@algonoah algonoah mentioned this pull request Aug 10, 2022
Merged
@onetechnical onetechnical mentioned this pull request Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cce cce cce left review comments

@id-ms id-ms id-ms approved these changes

@winder winder winder approved these changes

Assignees
No one assigned
Labels
Bug-Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Aharonee @cce @winder @id-ms