Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stateproof message #4006

Merged
merged 12 commits into from
May 20, 2022
Merged

Conversation

id-ms
Copy link
Contributor

@id-ms id-ms commented May 18, 2022

Summary

Test Plan

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #4006 (f6d2627) into feature/stateproofs (1df452a) will increase coverage by 4.68%.
The diff coverage is 86.15%.

@@                   Coverage Diff                   @@
##           feature/stateproofs    #4006      +/-   ##
=======================================================
+ Coverage                49.93%   54.61%   +4.68%     
=======================================================
  Files                      412      394      -18     
  Lines                    69231    48671   -20560     
=======================================================
- Hits                     34572    26584    -7988     
+ Misses                   30932    19877   -11055     
+ Partials                  3727     2210    -1517     
Impacted Files Coverage Δ
crypto/stateproof/weights.go 100.00% <ø> (ø)
data/stateproofmsg/message.go 0.00% <ø> (ø)
data/bookkeeping/sha256BlockHeader.go 80.00% <80.00%> (ø)
stateproof/stateproofMessageGenerator.go 81.39% <81.39%> (ø)
crypto/stateproof/builder.go 89.21% <100.00%> (+0.21%) ⬆️
crypto/stateproof/verifier.go 80.00% <100.00%> (+1.73%) ⬆️
stateproof/builder.go 67.15% <100.00%> (ø)
stateproof/signer.go 50.00% <100.00%> (-4.55%) ⬇️
network/wsPeer.go 68.61% <0.00%> (-2.23%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df452a...f6d2627. Read the comment docs.

Copy link
Contributor

@algonautshant algonautshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!
A few minor comments.

stateproof/stateproofMessageGenerator.go Outdated Show resolved Hide resolved
stateproof/stateproofMessageGenerator.go Outdated Show resolved Hide resolved
stateproof/stateproofMessageGenerator.go Outdated Show resolved Hide resolved
data/stateproofmsg/message.go Show resolved Hide resolved
@id-ms id-ms merged commit 906f615 into algorand:feature/stateproofs May 20, 2022
@id-ms id-ms deleted the stateproof-message branch October 25, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants