Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVM: Consolidate TEAL and AVM versioning #4269

Merged
merged 8 commits into from
Jul 20, 2022

Conversation

michaeldiamant
Copy link
Contributor

@michaeldiamant michaeldiamant commented Jul 15, 2022

Consolidates TEAL and AVM versioning references as requested in #4125.

Diffs produced by:

  • Searching for (case insensitive) "teal version", "tealversion", and "teal v" references.
  • Reviewing the spec (data/transactions/logic/README.md).

@michaeldiamant michaeldiamant changed the title AVM: Consolidate TEAL and AVM versioniong AVM: Consolidate TEAL and AVM versioning Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #4269 (4cdd3cf) into master (315037b) will decrease coverage by 0.05%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master    #4269      +/-   ##
==========================================
- Coverage   55.24%   55.19%   -0.06%     
==========================================
  Files         395      395              
  Lines       50219    50219              
==========================================
- Hits        27743    27717      -26     
- Misses      20101    20120      +19     
- Partials     2375     2382       +7     
Impacted Files Coverage Δ
data/transactions/logic/assembler.go 85.09% <ø> (ø)
data/transactions/logic/fields.go 77.10% <ø> (ø)
data/transactions/logic/opcodes.go 83.87% <ø> (ø)
protocol/consensus.go 0.00% <ø> (ø)
data/transactions/verify/txn.go 44.00% <25.00%> (-0.89%) ⬇️
data/transactions/logic/eval.go 90.00% <100.00%> (ø)
data/transactions/verify/verifiedTxnCache.go 77.55% <100.00%> (ø)
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
network/wsPeer.go 65.47% <0.00%> (-2.74%) ⬇️
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
... and 6 more

@michaeldiamant michaeldiamant marked this pull request as ready for review July 15, 2022 20:43
Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@iten-alg iten-alg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple lines that are maybe relevant (if we decide these are I can go find similar ones):
->line 678 of opcodes.go says "v2 TEAL"
->line 17 of rekey.sh says "v2 TEAL"
Sorry I couldn't find a way in github to add suggestions to these lines.

@michaeldiamant
Copy link
Contributor Author

couple lines that are maybe relevant

@iten-alg Thanks for catching - I updated via 2615784 using git --no-pager grep -P "v\d TEAL" to catch references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants