-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVM: Consolidate TEAL and AVM versioning #4269
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4269 +/- ##
==========================================
- Coverage 55.24% 55.19% -0.06%
==========================================
Files 395 395
Lines 50219 50219
==========================================
- Hits 27743 27717 -26
- Misses 20101 20120 +19
- Partials 2375 2382 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Co-authored-by: iten-alg <[email protected]>
Co-authored-by: iten-alg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple lines that are maybe relevant (if we decide these are I can go find similar ones):
->line 678 of opcodes.go says "v2 TEAL"
->line 17 of rekey.sh says "v2 TEAL"
Sorry I couldn't find a way in github to add suggestions to these lines.
…gorand into avm_version_consolidation
Consolidates TEAL and AVM versioning references as requested in #4125.
Diffs produced by:
data/transactions/logic/README.md
).