Test: Make e2e subs report individual results better #4286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannotti
force-pushed
the
e2e-subs-breakdown
branch
from
c7dffab
to
e78e01c
Compare
Codecov Report
@@ Coverage Diff @@
## master #4286 +/- ##
==========================================
+ Coverage 55.25% 55.32% +0.07%
==========================================
Files 395 395
Lines 50333 50333
==========================================
+ Hits 27809 27849 +40
+ Misses 20136 20096 -40
Partials 2388 2388
Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
I think this could be cleaner with jsonfile and event_log as members of RunSet (they're always used with that context available, so shouldn't be hard). Otherwise looks good. |
Agree, I'll move it. I don't like that |
brianolson
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent is to make CircleCI aware of individual tests in e2e subs.
e2e_client_runner now spits out a gotest compatible json file if TEST_RESULTS is set, then converts it to junit xml using gotestsum (since that's what CircleCI understands).
Some aspects of the client runner that caused it to terminate tests early after one failure were removed, so now the failures can be individually reported.