CI: Add parameter to run Nightly Test #4299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algobarb
changed the title
|
I cancelled the nightly tests since I just wanted to test to see if they would run with a triggered parameter and whether it would upload the file as expected. |
winder
reviewed
Jul 26, 2022
| @@ -15,6 +15,9 @@ parameters: | |||
| result_path: | |||
| type: string | |||
| default: "/tmp/build_test_results" | |||
| valid_nightly_branch: | |||
| type: string | |||
| default: /hotfix\/.*/ | |||
algorandskiy
approved these changes
Jul 26, 2022
cce
approved these changes
Jul 26, 2022
algojack
approved these changes
Jul 26, 2022
winder
pushed a commit
to winder/go-algorand
that referenced
this pull request
Jul 26, 2022
* Remove double-quotes and comments * test adding valid_nightly_branch parameter * update CI_E2E_FILENAME * change circleci branch reference * change where the variable is referenced * add parameter expansion * revert script name changes. Remove nightly from name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to easily run nightly test on any branch in the main repo.
Nightly tests remove the
-shortflag from tests. They are longer and more thorough. These tests are important especially for large feature branches.With these changes, algorand devs can Trigger a pipeline on a branch in the go-algorand repo with:
valid_nightly_branch: {current_branch_name}, e.g.valid_nightly_branch: test/master-copy2Test Plan
Triggered the CircleCI job manually and provided the parameter. Made sure the filename is uploaded.
https://app.circleci.com/pipelines/github/algorand/go-algorand?branch=test%2Fmaster-copy2