Ledger: remove txtail from data race test #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ghost
requested a review
from 
jannotti
reviewed
Jul 27, 2022
ledger/acctupdates_test.go
Outdated
| @@ -608,6 +608,9 @@ func TestAcctUpdatesFastUpdates(t *testing.T) { | |||
| defer au.close() | |||
| defer ao.close() | |||
|
|
|||
| // remove the txtail from the list of trackers | |||
There was a problem hiding this comment.
Could you included your explanation from the PR here?
Codecov Report
@@ Coverage Diff @@
## master #4315 +/- ##
=======================================
Coverage 55.25% 55.25%
=======================================
Files 395 395
Lines 50333 50333
=======================================
Hits 27814 27814
+ Misses 20133 20130 -3
- Partials 2386 2389 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. |
algorandskiy
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
TestAcctUpdatesFastUpdatestest callscommittedUpToandnewBlockasynchronously with no locking, which causes a data race in the txtail. Since under normal operation these calls are protected by the tracker mutex, we can simply remove the txtail in this test to avoid test failure.Test Plan
This is a test