tools: adapt loadgenerator to cluster testing #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add -d ALGORAND_DATA for use like pingpong
add -config '{json literal}'
cce
reviewed
Jul 29, 2022
cce
reviewed
Jul 29, 2022
| var err error | ||
| nodeStatus, err = restClient.Status() |
There was a problem hiding this comment.
oh OK without this change, multiple loadgenerators wouldn't necessarily all target the same block... but one might also miss the block (like we were seeing) if something slow happens between waitForRound and generateTransactions?
There was a problem hiding this comment.
I can't think of any reason why you would miss the round by the time you get around to sending, unless the node you're talking to was running behind or something
Codecov Report
@@ Coverage Diff @@
## master #4324 +/- ##
=======================================
Coverage 55.29% 55.29%
=======================================
Files 395 395
Lines 50334 50334
=======================================
Hits 27831 27831
- Misses 20111 20117 +6
+ Partials 2392 2386 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. |
cce
reviewed
Aug 1, 2022
| // Like shared/pingpong/accounts.go | ||
| func findRootKeys(algodDir string) []*crypto.SignatureSecrets { | ||
| keylist := make([]*crypto.SignatureSecrets, 0, 5) | ||
| err := filepath.Walk(algodDir, func(path string, info fs.FileInfo, err error) error { |
There was a problem hiding this comment.
nit, I think filepath.Walk wants you to do this with the err:
Suggested change
| err := filepath.Walk(algodDir, func(path string, info fs.FileInfo, err error) error { | |
| err := filepath.Walk(algodDir, func(path string, info fs.FileInfo, err error) error { | |
| if err != nil { | |
| return err | |
| } |
cce
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add -d ALGORAND_DATA for use like pingpong
add -config '{json literal}'
Test Plan
This has recently been used extensively in manual testing.