Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed StateProofIntervalLastRound and usages #4337

Merged

Conversation

almog-t
Copy link
Contributor

@almog-t almog-t commented Aug 2, 2022

Summary

Test Plan

@almog-t almog-t requested a review from id-ms August 2, 2022 08:05
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #4337 (d4cfbc6) into feature/stateproofs (b995c5d) will increase coverage by 0.02%.
The diff coverage is 53.12%.

@@                   Coverage Diff                   @@
##           feature/stateproofs    #4337      +/-   ##
=======================================================
+ Coverage                55.57%   55.59%   +0.02%     
=======================================================
  Files                      401      401              
  Lines                    50690    50687       -3     
=======================================================
+ Hits                     28172    28181       +9     
+ Misses                   20132    20121      -11     
+ Partials                  2386     2385       -1     
Impacted Files Coverage Δ
crypto/merklesignature/merkleSignatureScheme.go 66.97% <0.00%> (ø)
daemon/algod/api/server/v1/handlers/handlers.go 0.63% <0.00%> (+<0.01%) ⬆️
data/basics/stateProofParticipant.go 0.00% <0.00%> (ø)
ledger/apply/stateproof.go 0.00% <0.00%> (ø)
stateproof/builder.go 76.99% <ø> (-0.11%) ⬇️
crypto/merklesignature/committablePublicKeys.go 88.23% <100.00%> (ø)
crypto/stateproof/coinGenerator.go 100.00% <100.00%> (ø)
crypto/stateproof/committableSignatureSlot.go 65.21% <100.00%> (ø)
data/pools/transactionPool.go 52.81% <100.00%> (ø)
data/transactions/stateproof.go 100.00% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Contributor

@id-ms id-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@id-ms id-ms merged commit 883bbbd into algorand:feature/stateproofs Aug 2, 2022
@almog-t almog-t deleted the remove_redundant_sp_txn_field branch August 2, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants