tests: extended logging on expect test abort #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
force-pushed
the
pavel/expect-test-logs
branch
from
1fa2b0f
to
2215ac9
Compare
algonautshant
approved these changes
Aug 2, 2022
Codecov Report
@@ Coverage Diff @@
## master #4343 +/- ##
=======================================
Coverage 55.23% 55.24%
=======================================
Files 395 395
Lines 50351 50351
=======================================
+ Hits 27813 27817 +4
+ Misses 20145 20143 -2
+ Partials 2393 2391 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. |
| @@ -50,11 +50,41 @@ proc ::AlgorandGoal::Abort { ERROR } { | |||
| # terminate child algod processes, if there are active child processes the test will hang on a test failure | |||
| puts "GLOBAL_TEST_ROOT_DIR $::GLOBAL_TEST_ROOT_DIR" | |||
| puts "GLOBAL_NETWORK_NAME $::GLOBAL_NETWORK_NAME" | |||
|
|
|||
| log_user 1 | |||
| set NODE_DATA_DIR $GLOBAL_TEST_ROOT_DIR/Primary | |||
There was a problem hiding this comment.
What if Primary and Node are not the names used by a test?
WaitForRound gets the node dir as param: { WAIT_FOR_ROUND_NUMBER NODE_DATA_DIR
which takes care of this possibility, but not here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved logs printing from
WaitForRoundtoAbortmethod.Sometimes expect tests fail with messages like this that do not help at all.
Now test output has more details.