Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StateProofs: fix fast catchup bug #4346

Merged
merged 3 commits into from
Aug 3, 2022

Conversation

id-ms
Copy link
Contributor

@id-ms id-ms commented Aug 3, 2022

Summary

Test Plan

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #4346 (e01d0de) into feature/stateproofs (883bbbd) will decrease coverage by 0.05%.
The diff coverage is 76.92%.

@@                   Coverage Diff                   @@
##           feature/stateproofs    #4346      +/-   ##
=======================================================
- Coverage                55.70%   55.64%   -0.06%     
=======================================================
  Files                      401      401              
  Lines                    50687    50700      +13     
=======================================================
- Hits                     28233    28212      -21     
- Misses                   20073    20110      +37     
+ Partials                  2381     2378       -3     
Impacted Files Coverage Δ
catchup/catchpointService.go 2.52% <76.92%> (+2.52%) ⬆️
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
catchup/service.go 69.38% <0.00%> (-2.97%) ⬇️
node/node.go 23.01% <0.00%> (-2.39%) ⬇️
util/db/dbutil.go 49.09% <0.00%> (-1.22%) ⬇️
network/wsNetwork.go 64.70% <0.00%> (-0.20%) ⬇️
ledger/accountdb.go 72.65% <0.00%> (-0.09%) ⬇️
network/wsPeer.go 68.21% <0.00%> (+0.54%) ⬆️
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@id-ms id-ms requested review from algorandskiy and cce August 3, 2022 15:46
@id-ms id-ms changed the title fix fast catchup bug StateProofs: fix fast catchup bug Aug 3, 2022
catchup/catchpointService.go Outdated Show resolved Hide resolved
catchup/catchpointService.go Outdated Show resolved Hide resolved
catchup/catchpointService.go Outdated Show resolved Hide resolved
@id-ms id-ms merged commit 2db080f into algorand:feature/stateproofs Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants