Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix TestAccountsCanSendMoney #4354

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 4, 2022

Summary

The TestAccountsCanSendMoney test flakes and sometimes returns that an account has a different balance than expected. This happens because we don't wait for all txns to confirm, only a set of them. Fix it such that we wait for all txns to confirm.

Test Plan

This is a test.

@ghost ghost self-assigned this Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #4354 (f7906df) into master (7a56ea7) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4354      +/-   ##
==========================================
- Coverage   55.23%   55.21%   -0.02%     
==========================================
  Files         395      395              
  Lines       50352    50352              
==========================================
- Hits        27811    27804       -7     
- Misses      20149    20155       +6     
- Partials     2392     2393       +1     
Impacted Files Coverage Δ
ledger/tracker.go 71.79% <0.00%> (-5.56%) ⬇️
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
catchup/service.go 68.88% <0.00%> (-1.24%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
data/transactions/verify/txn.go 44.00% <0.00%> (-0.89%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
ledger/acctupdates.go 70.52% <0.00%> (+0.60%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
network/wsPeer.go 67.67% <0.00%> (+2.19%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants