Stateproofs: Reduce num reveals #4355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/stateproofs #4355 +/- ##
=======================================================
- Coverage 55.70% 55.60% -0.10%
=======================================================
Files 401 402 +1
Lines 50687 50703 +16
=======================================================
- Hits 28233 28192 -41
- Misses 20073 20131 +58
+ Partials 2381 2380 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
algorandskiy
reviewed
Aug 4, 2022
crypto/stateproof/weights_test.go
Outdated
Comment on lines
133
to
136
| provenWtRatio := 3 - (float64(168) / 100) | ||
| provenWt := uint64(float64(sigWt) / (provenWtRatio)) | ||
| lnProvenWt, err := LnIntApproximation(provenWt) | ||
| a.NoError(err) |
There was a problem hiding this comment.
nit: call checkRatio(168, ...) and return lnProvenWt ?
algorandskiy
approved these changes
Aug 5, 2022
id-ms
force-pushed
the
reduce-num-reveals
branch
from
f0f0bbf
to
1cab09b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan