Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestSPWithCounterReset make it more tolerant #4366

Conversation

algonautshant
Copy link
Contributor

@algonautshant algonautshant commented Aug 6, 2022

Occasionally the bad SP take over the valid SP and prevent the node from creating the SP. The test fails.
Giving the test more time and enhance the odds of passing.

@algonautshant algonautshant changed the base branch from master to feature/stateproofs August 6, 2022 03:47
@codecov
Copy link

codecov bot commented Aug 7, 2022

Codecov Report

Merging #4366 (1e830ee) into feature/stateproofs (eaeeade) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##           feature/stateproofs    #4366      +/-   ##
=======================================================
- Coverage                55.63%   55.61%   -0.03%     
=======================================================
  Files                      402      402              
  Lines                    50773    50773              
=======================================================
- Hits                     28248    28237      -11     
- Misses                   20137    20143       +6     
- Partials                  2388     2393       +5     
Impacted Files Coverage Δ
ledger/tracker.go 72.64% <0.00%> (-5.99%) ⬇️
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
ledger/acctonline.go 78.47% <0.00%> (-0.53%) ⬇️
ledger/accountdb.go 72.58% <0.00%> (-0.16%) ⬇️
ledger/acctupdates.go 70.52% <0.00%> (+0.15%) ⬆️
network/wsNetwork.go 65.08% <0.00%> (+0.19%) ⬆️
data/transactions/verify/txn.go 44.88% <0.00%> (+0.88%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@algonautshant algonautshant merged commit d96506d into algorand:feature/stateproofs Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants