test: fix TestAccountsCanSendMoney #2

[ghost]

Summary

The TestAccountsCanSendMoney test is still flaky and this pr aims to fix it. Another problem observed was that the test aims to check the balances of both accounts are correct on both ping and pong nodes by calling the fixture.GetBalanceAndRound function. However this function always calls the ping node and never the pong node. Thus we have logic which first ensures that the txns are confirmed on the pong node, then incorrectly checks the balances on the ping node instead of the pong node. The ping node may be out of sync and return the wrong balances.

This pr corrects this by checking the balance on the pong node instead of the ping node.

Test Plan

This is a test.

[algorandskiy]

The fix looks good to me, thank you

[codecov]

Codecov Report

Merging #4374 (b7acbb2) into master (d7ed271) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4374      +/-   ##
==========================================
- Coverage   55.28%   55.24%   -0.05%     
==========================================
  Files         395      395              
  Lines       50352    50352              
==========================================
- Hits        27838    27815      -23     
- Misses      20119    20144      +25     
+ Partials     2395     2393       -2     

Impacted Files	Coverage Δ
network/wsPeer.go	65.47% <0.00%> (-2.47%)	⬇️
node/node.go	23.01% <0.00%> (-2.39%)	⬇️
crypto/merkletrie/trie.go	66.42% <0.00%> (-2.19%)	⬇️
crypto/merkletrie/node.go	91.62% <0.00%> (-1.87%)	⬇️
data/transactions/verify/txn.go	44.00% <0.00%> (-0.89%)	⬇️
network/wsNetwork.go	64.89% <0.00%> (-0.29%)	⬇️
ledger/tracker.go	76.49% <0.00%> (ø)
catchup/service.go	69.38% <0.00%> (+0.49%)	⬆️
cmd/tealdbg/debugger.go	73.49% <0.00%> (+0.80%)	⬆️
data/abi/abi_type.go	88.62% <0.00%> (+0.94%)	⬆️
... and 2 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more