Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: wait until new block is committed to BlockQueue #4381

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Conversation

ahangsu
Copy link
Contributor

@ahangsu ahangsu commented Aug 9, 2022

Summary

By #4349, we noticed a datarace in testMaxInnerTxnSingleAppCall. This PR waits the ledger to commit every new blocks in blockQueue to be committed in function endBlock.

@ahangsu ahangsu added test Improves testing of existing code Team Scytale Bug-Fix labels Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #4381 (01f78c9) into master (60fb4f6) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4381   +/-   ##
=======================================
  Coverage   55.60%   55.61%           
=======================================
  Files         403      403           
  Lines       50801    50801           
=======================================
+ Hits        28248    28251    +3     
+ Misses      20159    20157    -2     
+ Partials     2394     2393    -1     
Impacted Files Coverage Δ
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
ledger/acctupdates.go 69.92% <0.00%> (-0.61%) ⬇️
ledger/acctonline.go 78.47% <0.00%> (-0.53%) ⬇️
catchup/service.go 69.38% <0.00%> (ø)
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
util/db/dbutil.go 50.30% <0.00%> (+1.21%) ⬆️
network/wsPeer.go 67.67% <0.00%> (+2.19%) ⬆️
cmd/algoh/blockWatcher.go 80.95% <0.00%> (+3.17%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ahangsu ahangsu marked this pull request as ready for review August 9, 2022 19:24
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahangsu Thanks for the effort here - Hopefully, we've addressed a source of flakyness.

Additionally, I performed a cursory call hierarchy inspection for AddValidatedBlock. I found no production code paths liable for the same class of data race.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug-Fix Team Scytale test Improves testing of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants