Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algod: changed state proof message to no longer be embedded #4395

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

almog-t
Copy link
Contributor

@almog-t almog-t commented Aug 11, 2022

Summary

Changes to some API types - extracted StateProofMessage from StateProof, since SDK code generation does not currently behave as expected when processing embedded types.

Test Plan

@almog-t almog-t requested a review from id-ms August 11, 2022 15:23
@almog-t almog-t changed the title changed state proof message to no longer be embedded Algod: changed state proof message to no longer be embedded Aug 11, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #4395 (cc15c47) into master (701d431) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4395      +/-   ##
==========================================
- Coverage   55.63%   55.59%   -0.04%     
==========================================
  Files         403      403              
  Lines       50805    50805              
==========================================
- Hits        28263    28246      -17     
- Misses      20148    20167      +19     
+ Partials     2394     2392       -2     
Impacted Files Coverage Δ
catchup/service.go 68.14% <0.00%> (-1.98%) ⬇️
ledger/tracker.go 78.63% <0.00%> (-1.71%) ⬇️
util/db/dbutil.go 49.09% <0.00%> (-1.22%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
ledger/acctupdates.go 69.92% <0.00%> (-0.61%) ⬇️
network/requestTracker.go 71.12% <0.00%> (-0.44%) ⬇️
network/wsPeer.go 67.67% <0.00%> (ø)
data/transactions/verify/txn.go 44.73% <0.00%> (+0.87%) ⬆️
cmd/algoh/blockWatcher.go 80.95% <0.00%> (+3.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder marked this pull request as ready for review August 11, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants