Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use GHA for codegen_verification #4412

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Conversation

cce
Copy link
Contributor

@cce cce commented Aug 15, 2022

This moves the codegen_verification task to Github Actions, as it is similar to the other types of static checks and linting jobs already in GHA.

@cce cce changed the title CI: use6 GHA for codegen_verification CI: use GHA for codegen_verification Aug 15, 2022
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #4412 (52f02f5) into master (fd488f8) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4412      +/-   ##
==========================================
- Coverage   55.34%   55.32%   -0.02%     
==========================================
  Files         400      400              
  Lines       50797    50797              
==========================================
- Hits        28112    28104       -8     
- Misses      20311    20315       +4     
- Partials     2374     2378       +4     
Impacted Files Coverage Δ
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
ledger/blockqueue.go 84.48% <0.00%> (-2.88%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
ledger/tracker.go 73.93% <0.00%> (-0.86%) ⬇️
network/wsNetwork.go 64.70% <0.00%> (-0.20%) ⬇️
network/wsPeer.go 67.67% <0.00%> (ø)
ledger/acctonline.go 79.00% <0.00%> (+0.52%) ⬆️
ledger/acctupdates.go 70.52% <0.00%> (+0.60%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cce
Copy link
Contributor Author

cce commented Aug 15, 2022

manually compared the Github Actions output and the CircleCI output for codegen_verification on the same build and they look the same to me.

@cce cce marked this pull request as ready for review August 15, 2022 21:25
@cce cce requested review from algojack, onetechnical, a team, algolucky and winder August 15, 2022 21:25
winder
winder previously approved these changes Aug 16, 2022
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward.

@cce cce merged commit 1959dae into algorand:master Aug 16, 2022
@cce cce deleted the gha-codegen_verification branch August 16, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants