-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix logged panics in reproducible labels test #4446
tests: fix logged panics in reproducible labels test #4446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it not a problem that the panics are being made, and we can just suppress the logs?
Panics are in in level=panic, and this is fixed in fork() function as the PR description says. |
Codecov Report
@@ Coverage Diff @@
## master #4446 +/- ##
=======================================
Coverage 55.19% 55.20%
=======================================
Files 398 398
Lines 50165 50165
=======================================
+ Hits 27689 27693 +4
- Misses 20159 20161 +2
+ Partials 2317 2311 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Summary
Forked ledgers have not preserved protocol so that we logged errors from voters tracker.
Set logging level=info in tests that produce to much debug output while adding thousands of blocks.
Fixed onlineTotals call in checkUpdates for non-sense input values