Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix logged panics in reproducible labels test #4446

Merged

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Aug 22, 2022

Summary

Forked ledgers have not preserved protocol so that we logged errors from voters tracker.
Set logging level=info in tests that produce to much debug output while adding thousands of blocks.
Fixed onlineTotals call in checkUpdates for non-sense input values

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it not a problem that the panics are being made, and we can just suppress the logs?

@algorandskiy
Copy link
Contributor Author

Panics are in in level=panic, and this is fixed in fork() function as the PR description says.
The logs are for ledger.AddValidatedBlock messages when we add thousands of blocks in a test

ghost
ghost previously approved these changes Aug 22, 2022
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #4446 (706ba58) into master (e4d6d42) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4446   +/-   ##
=======================================
  Coverage   55.19%   55.20%           
=======================================
  Files         398      398           
  Lines       50165    50165           
=======================================
+ Hits        27689    27693    +4     
- Misses      20159    20161    +2     
+ Partials     2317     2311    -6     
Impacted Files Coverage Δ
ledger/tracker.go 73.93% <0.00%> (-0.86%) ⬇️
ledger/acctupdates.go 69.29% <0.00%> (-0.60%) ⬇️
ledger/acctonline.go 78.36% <0.00%> (-0.53%) ⬇️
catchup/service.go 69.38% <0.00%> (ø)
data/transactions/verify/txn.go 43.75% <0.00%> (ø)
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy requested a review from a user August 23, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant