-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Re-introduce build_nightly workflow to persist artifacts for upload_binaries #4457
CI: Re-introduce build_nightly workflow to persist artifacts for upload_binaries #4457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@algojack and I discussed forcing the nightly build to run prior to merging in order to validate the change. We've done so in a child PR: michaeldiamant#3. The build is running in https://app.circleci.com/pipelines/github/algorand/go-algorand/9011/workflows/72c36c87-93ab-466b-b932-6f9b7c886b9f. |
Codecov Report
@@ Coverage Diff @@
## master #4457 +/- ##
==========================================
+ Coverage 55.25% 55.26% +0.01%
==========================================
Files 398 398
Lines 50265 50265
==========================================
+ Hits 27772 27781 +9
+ Misses 20176 20168 -8
+ Partials 2317 2316 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary
Attempts to fix a regression in the nightly build introduced in #4426.
Notes:
upload_binaries
workflow fails to find artifacts to upload.build_nightly
workflow that builds + persists artifacts to the workspace. The approach mirrors the prior behavior (go-algorand/.circleci/config.yml
Lines 263 to 269 in 0b9580b
Test Plan
Sanity checked config changes via
circleci config validate
.