Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Re-introduce build_nightly workflow to persist artifacts for upload_binaries #4457

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

michaeldiamant
Copy link
Contributor

Summary

Attempts to fix a regression in the nightly build introduced in #4426.

Notes:

Test Plan

Sanity checked config changes via circleci config validate.

@michaeldiamant michaeldiamant changed the title Re-introduce build_nightly workflow to persist artifacts for upload_binaries CI: Re-introduce build_nightly workflow to persist artifacts for upload_binaries Aug 24, 2022
@onetechnical onetechnical requested review from a team, algobarb and algolucky August 24, 2022 18:41
Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaeldiamant
Copy link
Contributor Author

@algojack and I discussed forcing the nightly build to run prior to merging in order to validate the change. We've done so in a child PR: michaeldiamant#3.

The build is running in https://app.circleci.com/pipelines/github/algorand/go-algorand/9011/workflows/72c36c87-93ab-466b-b932-6f9b7c886b9f.

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #4457 (4121a4d) into master (0c09407) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4457      +/-   ##
==========================================
+ Coverage   55.25%   55.26%   +0.01%     
==========================================
  Files         398      398              
  Lines       50265    50265              
==========================================
+ Hits        27772    27781       +9     
+ Misses      20176    20168       -8     
+ Partials     2317     2316       -1     
Impacted Files Coverage Δ
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
network/wsPeer.go 68.21% <0.00%> (ø)
network/wsNetwork.go 64.82% <0.00%> (+0.19%) ⬆️
catchup/service.go 69.38% <0.00%> (+0.49%) ⬆️
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
agreement/proposalManager.go 98.03% <0.00%> (+1.96%) ⬆️
agreement/cryptoVerifier.go 69.71% <0.00%> (+2.11%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@algojack algojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants