Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: adding valid_nightly_branch var to upload_binaries step #4459

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

algojack
Copy link
Contributor

@algojack algojack commented Aug 24, 2022

@algojack algojack self-assigned this Aug 24, 2022
@algojack algojack requested review from a team, egieseke, algobarb and algolucky August 24, 2022 20:03
@algojack algojack marked this pull request as ready for review August 24, 2022 20:04
@algolucky
Copy link
Contributor

I like this change because then we can trigger nightlies from any branch without having to directly change code.

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #4459 (cde46d1) into master (0c09407) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4459      +/-   ##
==========================================
- Coverage   55.25%   55.22%   -0.03%     
==========================================
  Files         398      398              
  Lines       50265    50265              
==========================================
- Hits        27772    27759      -13     
- Misses      20176    20188      +12     
- Partials     2317     2318       +1     
Impacted Files Coverage Δ
ledger/tracker.go 74.89% <0.00%> (-2.98%) ⬇️
network/wsPeer.go 65.47% <0.00%> (-2.74%) ⬇️
catchup/service.go 68.64% <0.00%> (-0.25%) ⬇️
network/wsNetwork.go 64.63% <0.00%> (ø)
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy changed the title Adding valid_nightly_branch var to upload_binaries step build: adding valid_nightly_branch var to upload_binaries step Aug 25, 2022
@algorandskiy algorandskiy merged commit 7de989a into algorand:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants