Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catchup: increase HTTPFetcher fetcherMaxBlockBytes for larger block size #4569

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

cce
Copy link
Contributor

@cce cce commented Sep 22, 2022

Summary

When we grew the block size we did not adjust fetcherMaxBlockBytes to match, and it looks like we are running into this given errors like: response too large: 5265295 > 5242880.

Test Plan

Existing tests should pass.

@cce cce added the Bug-Fix label Sep 22, 2022
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #4569 (2b03964) into master (175d5aa) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4569      +/-   ##
==========================================
- Coverage   54.15%   54.15%   -0.01%     
==========================================
  Files         401      401              
  Lines       51628    51628              
==========================================
- Hits        27960    27959       -1     
- Misses      21319    21320       +1     
  Partials     2349     2349              
Impacted Files Coverage Δ
catchup/universalFetcher.go 96.22% <ø> (ø)
ledger/tracker.go 74.04% <0.00%> (-3.83%) ⬇️
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
network/wsNetwork.go 64.63% <0.00%> (ø)
cmd/algoh/blockWatcher.go 80.95% <0.00%> (+3.17%) ⬆️
network/wsPeer.go 70.88% <0.00%> (+4.85%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cce cce merged commit 8cb8ec6 into algorand:master Sep 22, 2022
@cce cce deleted the increase-fetcherMaxBlockBytes branch September 22, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants