Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Algod: state-proof key deletion safety #4601

Merged
merged 25 commits into from
Oct 26, 2022
Merged

Algod: state-proof key deletion safety #4601

merged 25 commits into from
Oct 26, 2022

Commits on Oct 23, 2022

  1. fix: stateprf deletes keys after stateproof advances.

    @algonathan
    algonathan authored and algoidan committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    8742b91 View commit details
    Browse the repository at this point in the history

  2. fixed unit test to match the current code of key deletion

    @algonathan
    algonathan authored and algoidan committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    b91d71c View commit details
    Browse the repository at this point in the history

  3. fix: all unit tests pass, added TODO

    @algonathan
    algonathan authored and algoidan committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    beb794a View commit details
    Browse the repository at this point in the history

  4. fx: comment

    @algonathan
    algonathan authored and algoidan committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    0199319 View commit details
    Browse the repository at this point in the history

  5. fx: deletion of previous rounds

    @algonathan
    algonathan authored and algoidan committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    5ad38a1 View commit details
    Browse the repository at this point in the history

  6. fx: unit-test

    @algonathan
    algonathan authored and algoidan committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    c8729b5 View commit details
    Browse the repository at this point in the history

  7. fx: prevStateproof init value

    @algonathan
    algonathan authored and algoidan committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    597008e View commit details
    Browse the repository at this point in the history

  8. fx: golangcli

    @algonathan
    algonathan authored and algoidan committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    dd00c9d View commit details
    Browse the repository at this point in the history

  9. fix merge issues.

    algoidan committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    cf10986 View commit details
    Browse the repository at this point in the history

  10. refactoring

    algoidan committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    c9d553f View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. add test

    algoidan committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    0e8a113 View commit details
    Browse the repository at this point in the history

  2. fix deletion bug

    algoidan committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    9e5ec61 View commit details
    Browse the repository at this point in the history

  3. fix tests

    algoidan committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    f14b837 View commit details
    Browse the repository at this point in the history

  4. refactoring tests

    algoidan committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    65d8b21 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. reuse code on tests

    algoidan committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    21cc86e View commit details
    Browse the repository at this point in the history

  2. fix keys removal to use the next state proof

    algoidan committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    48ef64d View commit details
    Browse the repository at this point in the history

  3. builder will not remove signatures and builder to support recoverability

    algoidan committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    6dd5a9e View commit details
    Browse the repository at this point in the history

  4. refactoring + avoid remove if stateproof was not changed

    algoidan committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    38b4f3d View commit details
    Browse the repository at this point in the history

  5. remove double test

    algoidan committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    d1dbb90 View commit details
    Browse the repository at this point in the history

  6. checking that the deletion round is not higher than expected

    @algonathan
    algonathan committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    b9fb7a7 View commit details
    Browse the repository at this point in the history

  7. minor refactor

    algoidan committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    cc22234 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. we now remove the last ephemeral key

    algoidan committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    100c282 View commit details
    Browse the repository at this point in the history

  2. nits

    algoidan committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    c5f89f1 View commit details
    Browse the repository at this point in the history

  3. add test for deleting all keys in account manger

    algoidan committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    abb58c1 View commit details
    Browse the repository at this point in the history

  4. move warning message to error

    algoidan committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    ae5aa9b View commit details
    Browse the repository at this point in the history