-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf test: Transaction group handle/verify #4652
Perf test: Transaction group handle/verify #4652
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4652 +/- ##
==========================================
+ Coverage 54.34% 54.41% +0.06%
==========================================
Files 402 402
Lines 51793 51793
==========================================
+ Hits 28149 28183 +34
+ Misses 21276 21233 -43
- Partials 2368 2377 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tweak, otherwise looks good
outChan := make(chan *txBacklogMsg, 10) | ||
wg := sync.WaitGroup{} | ||
wg.Add(1) | ||
// Make a test backlog worker, which is simiar to backlogWorker, but sends the results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a comment in txHandler.go at backlogWorker() noting that updates should be reflected in this test
Performance test for incoming transaction group handling/verifying.
Prepares transaction groups of random sizes, sends them to the handler, which verifies and returns the results.
The transaction group sizes are random. Introduces 10% invalid signatures and makes sure they are properly reported.