Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf test: Transaction group handle/verify #4652

Merged
merged 12 commits into from
Oct 24, 2022

Conversation

algonautshant
Copy link
Contributor

@algonautshant algonautshant commented Oct 14, 2022

Performance test for incoming transaction group handling/verifying.
Prepares transaction groups of random sizes, sends them to the handler, which verifies and returns the results.
The transaction group sizes are random. Introduces 10% invalid signatures and makes sure they are properly reported.

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #4652 (41a37df) into master (bb7c59f) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4652      +/-   ##
==========================================
+ Coverage   54.34%   54.41%   +0.06%     
==========================================
  Files         402      402              
  Lines       51793    51793              
==========================================
+ Hits        28149    28183      +34     
+ Misses      21276    21233      -43     
- Partials     2368     2377       +9     
Impacted Files Coverage Δ
data/txHandler.go 25.92% <ø> (+14.81%) ⬆️
ledger/tracker.go 74.89% <0.00%> (-3.83%) ⬇️
data/transactions/verify/txn.go 76.19% <0.00%> (-0.96%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
network/wsNetwork.go 64.76% <0.00%> (+0.19%) ⬆️
catchup/service.go 69.62% <0.00%> (+0.74%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️
data/ledger.go 45.25% <0.00%> (+13.86%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algonautshant algonautshant changed the title Shant/perf on master Perf: Transaction group handle/verify Oct 15, 2022
@cce cce changed the title Perf: Transaction group handle/verify Perf test: Transaction group handle/verify Oct 20, 2022
Copy link
Contributor

@brianolson brianolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tweak, otherwise looks good

outChan := make(chan *txBacklogMsg, 10)
wg := sync.WaitGroup{}
wg.Add(1)
// Make a test backlog worker, which is simiar to backlogWorker, but sends the results
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment in txHandler.go at backlogWorker() noting that updates should be reflected in this test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Release-Notes Team Carbon-11 test Improves testing of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants