Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algod: turn off cadaver trace file by default #4676

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

brianolson
Copy link
Contributor

Summary

Turn off the 'cadaver' trace file by default. It was used extensively in debugging years ago but hasn't been used much recently, and it significantly decreases performance. It can be re-enabled for debug clusters.

Test Plan

Many test clusters have been run with this disabled.

egieseke
egieseke previously approved these changes Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #4676 (793de59) into master (36c81fb) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4676      +/-   ##
==========================================
- Coverage   54.37%   54.34%   -0.03%     
==========================================
  Files         407      407              
  Lines       52389    52389              
==========================================
- Hits        28486    28473      -13     
- Misses      21523    21532       +9     
- Partials     2380     2384       +4     
Impacted Files Coverage Δ
config/localTemplate.go 40.00% <ø> (ø)
ledger/voters.go 68.65% <0.00%> (-4.48%) ⬇️
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
ledger/catchpointtracker.go 61.84% <0.00%> (-1.05%) ⬇️
ledger/acctonline.go 77.60% <0.00%> (-0.53%) ⬇️
ledger/accountdb.go 72.69% <0.00%> (-0.32%) ⬇️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@onetechnical onetechnical merged commit 36fc7f9 into algorand:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants