-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
algod: turn off cadaver trace file by default #4676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egieseke
previously approved these changes
Oct 20, 2022
algolucky
reviewed
Oct 20, 2022
Codecov Report
@@ Coverage Diff @@
## master #4676 +/- ##
==========================================
- Coverage 54.37% 54.34% -0.03%
==========================================
Files 407 407
Lines 52389 52389
==========================================
- Hits 28486 28473 -13
- Misses 21523 21532 +9
- Partials 2380 2384 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algojack
approved these changes
Oct 20, 2022
egieseke
approved these changes
Oct 20, 2022
algojack
requested review from
algojack,
egieseke,
algolucky,
algorandskiy and
cce
October 20, 2022 18:00
algorandskiy
approved these changes
Oct 20, 2022
algobarb
approved these changes
Oct 20, 2022
algojack
approved these changes
Oct 20, 2022
This was referenced Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Turn off the 'cadaver' trace file by default. It was used extensively in debugging years ago but hasn't been used much recently, and it significantly decreases performance. It can be re-enabled for debug clusters.
Test Plan
Many test clusters have been run with this disabled.