network: align duplicateFilterCount to prevent panic on 32-bit platforms #4702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -103,6 +103,7 @@ func TestAtomicVariablesAlignment(t *testing.T) { | |||
| require.True(t, (unsafe.Offsetof(p.requestNonce)%8) == 0) | |||
| require.True(t, (unsafe.Offsetof(p.lastPacketTime)%8) == 0) | |||
| require.True(t, (unsafe.Offsetof(p.intermittentOutgoingMessageEnqueueTime)%8) == 0) | |||
| require.True(t, (unsafe.Offsetof(p.duplicateFilterCount)%8) == 0) | |||
There was a problem hiding this comment.
Maybe the test needs to loop through all the fields and make sure they are all fine, instead of checking just a handful?
There was a problem hiding this comment.
only fields that are used by atomic.LoadInt64, atomic.StoreInt64, atomic.AddInt64, etc.. have to be here, and these are the only 4 fields in the network package that are used with these functions.
algorandskiy
previously approved these changes
Oct 27, 2022
brianolson
approved these changes
Oct 27, 2022
Codecov Report
@@ Coverage Diff @@
## master #4702 +/- ##
==========================================
- Coverage 54.49% 54.48% -0.01%
==========================================
Files 407 407
Lines 52389 52389
==========================================
- Hits 28548 28544 -4
- Misses 21455 21457 +2
- Partials 2386 2388 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #4631 by aligning a 64-bit counter when used on 32-bit platforms.
Test Plan
Updated TestAtomicVariablesAlignment.