Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Util: Print dbutil.go error in stderr #4712

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

michaeldiamant
Copy link
Contributor

Addresses #4149 (comment) by switching from stdout to stderr.

@michaeldiamant michaeldiamant changed the title Print dbutil.go error in stderr Util: Print dbutil.go error in stderr Oct 31, 2022
@michaeldiamant michaeldiamant marked this pull request as ready for review October 31, 2022 18:58
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #4712 (e20daa1) into master (0cb9a2e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4712      +/-   ##
==========================================
- Coverage   54.19%   54.17%   -0.02%     
==========================================
  Files         413      413              
  Lines       53408    53408              
==========================================
- Hits        28943    28935       -8     
- Misses      22056    22067      +11     
+ Partials     2409     2406       -3     
Impacted Files Coverage Δ
util/db/dbutil.go 42.60% <0.00%> (ø)
network/wsPeer.go 66.50% <0.00%> (-1.95%) ⬇️
ledger/tracker.go 74.04% <0.00%> (-0.86%) ⬇️
ledger/acctupdates.go 68.56% <0.00%> (-0.75%) ⬇️
network/wsNetwork.go 65.34% <0.00%> (-0.19%) ⬇️
network/requestTracker.go 71.55% <0.00%> (+0.43%) ⬆️
ledger/testing/randomAccounts.go 57.23% <0.00%> (+0.61%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy merged commit fb1f498 into algorand:master Oct 31, 2022
@michaeldiamant michaeldiamant deleted the stderr branch October 31, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants