Consensus: v36 upgrade #4722
Merged
Consensus: v36 upgrade #4722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onetechnical
reviewed
Nov 1, 2022
algorandskiy
previously approved these changes
Nov 1, 2022
michaeldiamant
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
@jannotti Looks accurate to me though I have little experience managing consensus upgrades. I prefer 1+ other approvals prior to merging.
gmalouf
approved these changes
Nov 1, 2022
cce
approved these changes
Nov 1, 2022
Codecov Report
@@ Coverage Diff @@
## master #4722 +/- ##
==========================================
- Coverage 54.37% 54.37% -0.01%
==========================================
Files 414 414
Lines 53504 53502 -2
==========================================
- Hits 29095 29091 -4
- Misses 22002 22007 +5
+ Partials 2407 2404 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows upgrade to v36, with boxes.