Goal: add --start option for network create command #4902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mciccarello
requested review from
winder,
AlgoStephenAkiki and
Eric-Warehime
Codecov Report
@@ Coverage Diff @@
## master #4902 +/- ##
==========================================
+ Coverage 53.52% 53.54% +0.01%
==========================================
Files 422 422
Lines 53852 53859 +7
==========================================
+ Hits 28826 28840 +14
+ Misses 22704 22699 -5
+ Partials 2322 2320 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@winder could use a review |
winder
previously approved these changes
Jan 11, 2023
AlgoStephenAkiki
previously approved these changes
Jan 11, 2023
algorandskiy
requested changes
Jan 19, 2023
cmd/goal/network.go
Outdated
| @@ -112,6 +114,16 @@ var networkCreateCmd = &cobra.Command{ | |||
| } | |||
|
|
|||
| reportInfof(infoNetworkCreated, network.Name(), networkRootDir) | |||
|
|
|||
| if startOnCreation { | |||
| fmt.Printf("startOnCreation true\n") | |||
There was a problem hiding this comment.
please remove the debug output
mciccarello
dismissed stale reviews from AlgoStephenAkiki and winder
via
2859a93
AlgoStephenAkiki
approved these changes
Jan 30, 2023
winder
approved these changes
Jan 30, 2023
algorandskiy
approved these changes
Jan 30, 2023
algorandskiy
changed the title
This was referenced Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added --start flag to "goal network create" that will cause the network to be run after creation.
Test Plan
Manually run.