Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest api: update WaitForBlock summary #4910

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

algorandskiy
Copy link
Contributor

Summary

WaitForBlock waits for r+1 so updated the method summary.
Resolves https://github.com/algorand/go-algorand-internal/issues/1361

Test Plan

Existing tests

winder
winder previously approved these changes Dec 14, 2022
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #4910 (7d6c3fc) into master (c8121b0) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4910      +/-   ##
==========================================
+ Coverage   54.08%   54.11%   +0.03%     
==========================================
  Files         427      427              
  Lines       53528    53528              
==========================================
+ Hits        28948    28965      +17     
+ Misses      22314    22300      -14     
+ Partials     2266     2263       -3     
Impacted Files Coverage Δ
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
ledger/testing/randomAccounts.go 57.23% <0.00%> (+0.61%) ⬆️
ledger/tracker.go 78.90% <0.00%> (+0.84%) ⬆️
catchup/service.go 69.80% <0.00%> (+1.20%) ⬆️
network/wsPeer.go 71.36% <0.00%> (+2.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants