Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updater: fix update.sh parsing of latest version #4994

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

onetechnical
Copy link
Contributor

Summary

With the removal of S3 credential requirements, the updater script has an additional output line to indicate it's using anonymous credentials. This breaks the parsing of version. This changes the sed from counting lines to just taking the last line with tail.

Test Plan

Verify that nightly integration works properly.

@onetechnical
Copy link
Contributor Author

This might have broken nightly updaters, as they can't run their update.sh!

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #4994 (bb48b66) into master (ecdcbf9) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4994      +/-   ##
==========================================
- Coverage   53.63%   53.61%   -0.03%     
==========================================
  Files         432      432              
  Lines       54057    54057              
==========================================
- Hits        28996    28981      -15     
- Misses      22818    22826       +8     
- Partials     2243     2250       +7     
Impacted Files Coverage Δ
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
ledger/testing/randomAccounts.go 56.26% <0.00%> (-0.62%) ⬇️
data/transactions/verify/txn.go 70.24% <0.00%> (-0.49%) ⬇️
catchup/service.go 69.32% <0.00%> (ø)
network/wsNetwork.go 64.92% <0.00%> (+0.17%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@onetechnical onetechnical merged commit 8437076 into algorand:master Jan 10, 2023
@onetechnical onetechnical deleted the fix-updater branch January 10, 2023 17:17
winder pushed a commit to winder/go-algorand that referenced this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants