-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Fix PartitionTest Github Action #5006
Conversation
can we add some checks to ensure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes relatively seems similar to what was in the PR summary, so I think the changes look good if they've been tested.
Added a fix to error out properly if it doesn't run: broke up the piped commands into two and added set -e and tested on the bugs we had here. It was updated without noticing because it failed silently (without failing the job) |
Codecov Report
@@ Coverage Diff @@
## master #5006 +/- ##
=======================================
Coverage 53.50% 53.51%
=======================================
Files 429 429
Lines 54038 54038
=======================================
+ Hits 28911 28916 +5
+ Misses 22883 22879 -4
+ Partials 2244 2243 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Fixing partitionTest linter to work:
go mod tidy -compat=1.17
in cmd/partitiontest_linterTested locally and on github actions.