Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVM: Clearer cost benchmarks, and a nice optimization of b== and b< #5010

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

jannotti
Copy link
Contributor

Cleans up benchmarks in a way that should let us assign costs more easily, especially for costs that differ based on input size.

One such benchmark showed that "byte math compares" were all significantly improved by avoiding the use of big.Int, so that change is included.

@jannotti jannotti requested a review from ahangsu January 12, 2023 17:08
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #5010 (885c02d) into master (eddf773) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5010      +/-   ##
==========================================
- Coverage   53.63%   53.62%   -0.02%     
==========================================
  Files         432      432              
  Lines       54057    54060       +3     
==========================================
- Hits        28996    28992       -4     
- Misses      22812    22820       +8     
+ Partials     2249     2248       -1     
Impacted Files Coverage Δ
data/transactions/logic/eval.go 90.17% <100.00%> (+0.01%) ⬆️
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
ledger/tracker.go 74.26% <0.00%> (-0.85%) ⬇️
catchup/service.go 69.08% <0.00%> (-0.73%) ⬇️
ledger/acctupdates.go 69.24% <0.00%> (-0.25%) ⬇️
network/wsNetwork.go 64.92% <0.00%> (+0.17%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
agreement/proposalManager.go 98.03% <0.00%> (+1.96%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jannotti jannotti marked this pull request as ready for review January 12, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants