-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network: increase max incoming connections limit #5018
network: increase max incoming connections limit #5018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see a change here paired with lowering the per host connection limit (perhaps to 10) - know that is under discussion.
Codecov Report
@@ Coverage Diff @@
## master #5018 +/- ##
==========================================
- Coverage 53.62% 53.62% -0.01%
==========================================
Files 432 432
Lines 54060 54060
==========================================
- Hits 28991 28990 -1
Misses 22824 22824
- Partials 2245 2246 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Summary
According to the latest measurement a single connection consumes about 1 MiB of RAM (calculated 600 KiB measured lower bound is 800 KiB, upper bound is 1.5 MiB).
Setting
IncomingConnectionsLimit
to 2400 should have a total memory footprint of 3.6 GiB.Also decreased
MaxConnectionsPerIP
to 15 as a best guess based on a fact only fraction of nodes report hitting this limit.Test Plan
Existing tests