tests: disable TestInitialSync on CI #5053
Conversation
| @@ -245,6 +246,10 @@ func TestInitialSync(t *testing.T) { | |||
| t.Skip("Test takes ~25 seconds.") | |||
| } | |||
|
|
|||
| if strings.ToUpper(os.Getenv("CIRCLECI")) == "TRUE" { | |||
| t.Skip("Test is too heavy for amd64 builder running in parallel with other packages") | |||
There was a problem hiding this comment.
Is it really running in parallel with other packages though? I thought we don't allow that
There was a problem hiding this comment.
try make test and observe LA 100+ with all cores busy and 8+ test processes
There was a problem hiding this comment.
Is far as I know, tests do not run with others when t.Parallel() is not called.
That the the whole reason why we have multiple runs on CircleCi.
If we are running things in parallel, something has changed!
There was a problem hiding this comment.
t.Parallel() takes effect only within a single package (test binary)
There was a problem hiding this comment.
we disable package-level parallelism in CI by passing -p 1 in the .circleci/confiig.yml file though
There was a problem hiding this comment.
oh, I expected it calling make test. Then it is very weird it fails time to time
Codecov Report
@@ Coverage Diff @@
## master #5053 +/- ##
==========================================
- Coverage 53.57% 53.56% -0.02%
==========================================
Files 430 430
Lines 54091 54091
==========================================
- Hits 28979 28973 -6
- Misses 22868 22872 +4
- Partials 2244 2246 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
force-pushed
the
pavel/disable-test-initial-sync
branch
from
305eddf
to
8e3b681
Compare
Summary
TestInitialSync creates 10 full nodes that is too much for CI builder.
Test Plan
This is a test