Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: Add GetUnderlyingConnTcpInfo method to wsPeer #5077

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

iansuvak
Copy link
Contributor

Summary

Enables code outside of the network package to get TCPInfo of the underlying websocket connection.

Test Plan

Should pass existing tests

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #5077 (0e93433) into master (1ad3db9) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5077      +/-   ##
==========================================
+ Coverage   53.57%   53.58%   +0.01%     
==========================================
  Files         430      430              
  Lines       54091    54092       +1     
==========================================
+ Hits        28980    28986       +6     
+ Misses      22864    22861       -3     
+ Partials     2247     2245       -2     
Impacted Files Coverage Δ
network/wsNetwork.go 65.04% <0.00%> (+0.29%) ⬆️
network/wsPeer.go 65.50% <0.00%> (-0.93%) ⬇️
util/rateLimit.go 81.37% <0.00%> (-0.99%) ⬇️
ledger/tracker.go 74.26% <0.00%> (-0.85%) ⬇️
ledger/catchpointtracker.go 58.49% <0.00%> (ø)
data/transactions/logic/assembler.go 87.25% <0.00%> (+0.13%) ⬆️
catchup/service.go 70.53% <0.00%> (+0.72%) ⬆️
ledger/blockqueue.go 84.94% <0.00%> (+2.68%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy changed the title metrics: Add GetUnderlyingConnTcpInfo method to UnicastPeer interface metrics: Add GetUnderlyingConnTcpInfo method to wsPeer Jan 30, 2023
@algorandskiy algorandskiy changed the title metrics: Add GetUnderlyingConnTcpInfo method to wsPeer network: Add GetUnderlyingConnTcpInfo method to wsPeer Jan 30, 2023
algorandskiy
algorandskiy previously approved these changes Jan 30, 2023
@algorandskiy algorandskiy merged commit e85d752 into algorand:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants