Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: add an Enhancement issue-template #5091

Merged
merged 1 commit into from Feb 13, 2023
Merged

repo: add an Enhancement issue-template #5091

merged 1 commit into from Feb 13, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 1, 2023

Summary

The Enhancement label is there, and clearly the dev-processes here distinguish between New-Feature and Enhancement (see additionally the PR processing).

So there is no reason to not provide an issue-template, thus users can pick it right from the beginning:

https://github.com/algorand/go-algorand/issues/new/choose

Test Plan

a little bit on own repo, but is trivial

(please feel free to close this PR and create the template with your requirements from the github UI - should be here:

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #5091 (2cfc784) into master (8e5df38) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5091   +/-   ##
=======================================
  Coverage   53.53%   53.53%           
=======================================
  Files         430      430           
  Lines       54086    54086           
=======================================
+ Hits        28954    28955    +1     
+ Misses      22880    22879    -1     
  Partials     2252     2252           
Impacted Files Coverage Δ
ledger/voters.go 68.65% <0.00%> (-4.48%) ⬇️
ledger/blockqueue.go 82.25% <0.00%> (-2.69%) ⬇️
network/wsPeer.go 65.50% <0.00%> (-1.87%) ⬇️
cmd/tealdbg/debugger.go 71.65% <0.00%> (-0.79%) ⬇️
network/wsNetwork.go 65.04% <0.00%> (-0.19%) ⬇️
ledger/acctonline.go 78.64% <0.00%> (ø)
ledger/acctupdates.go 69.24% <0.00%> (+0.48%) ⬆️
ledger/catchpointtracker.go 57.92% <0.00%> (+0.78%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
catchup/service.go 69.80% <0.00%> (+1.20%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy changed the title add an Enhancement issue-template repo: add an Enhancement issue-template Feb 3, 2023
@ghost
Copy link
Author

ghost commented Feb 13, 2023

@barnjamin

@ghost
Copy link
Author

ghost commented Feb 13, 2023

@barnjamin , ty!

@algorandskiy , looks like this one needs 2 approvals...

@algorandskiy algorandskiy added this pull request to the merge queue Feb 13, 2023
@algojohnlee algojohnlee removed this pull request from the merge queue due to the queue being cleared Feb 13, 2023
@algorandskiy algorandskiy merged commit 02af4ca into algorand:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants