Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Message pack information. #5160

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

winder
Copy link
Contributor

@winder winder commented Feb 24, 2023

Summary

Was having a discussion about message pack and learned a couple things. Writing them down for posterity.

Test Plan

N/A

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #5160 (41e0de1) into master (a688c23) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5160      +/-   ##
==========================================
+ Coverage   53.44%   53.48%   +0.03%     
==========================================
  Files         431      431              
  Lines       54364    54364              
==========================================
+ Hits        29056    29074      +18     
+ Misses      23053    23040      -13     
+ Partials     2255     2250       -5     
Impacted Files Coverage Δ
ledger/testing/randomAccounts.go 55.65% <0.00%> (-1.23%) ⬇️
cmd/tealdbg/debugger.go 71.65% <0.00%> (-0.79%) ⬇️
data/transactions/logic/assembler.go 87.89% <0.00%> (-0.13%) ⬇️
ledger/tracker.go 75.10% <0.00%> (ø)
network/wsNetwork.go 65.34% <0.00%> (+0.18%) ⬆️
ledger/acctonline.go 79.16% <0.00%> (+0.52%) ⬆️
ledger/catchpointtracker.go 58.69% <0.00%> (+0.78%) ⬆️
catchup/service.go 70.35% <0.00%> (+1.41%) ⬆️
network/wsPeer.go 68.27% <0.00%> (+2.29%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder requested a review from cce February 25, 2023 17:22
@winder winder assigned winder and unassigned cce Feb 25, 2023
@winder winder marked this pull request as ready for review February 25, 2023 17:22
Copy link
Contributor

@onetechnical onetechnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@winder winder merged commit bee25d7 into algorand:master Mar 9, 2023
@winder winder deleted the will/msgp-doc branch March 9, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants