Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(follower): update test that defines a follower relay. #5162

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Feb 27, 2023

Summary

Fix a regression relating to stricter private network config validation. Follower configurations may no longer be marked as a relay.

Test Plan

Existing integration test. I think this change is compatible with the intent of the test that regressed.

@winder winder added the Bug-Fix label Feb 27, 2023
@winder winder marked this pull request as ready for review February 27, 2023 13:55
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #5162 (67ffdbb) into master (a688c23) will decrease coverage by 0.74%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5162      +/-   ##
==========================================
- Coverage   53.44%   52.71%   -0.74%     
==========================================
  Files         431      431              
  Lines       54364    54364              
==========================================
- Hits        29056    28658     -398     
- Misses      23053    23431     +378     
- Partials     2255     2275      +20     
Impacted Files Coverage Δ
data/committee/sortition/sortition.go 23.52% <0.00%> (-58.83%) ⬇️
network/messageFilter.go 33.33% <0.00%> (-51.29%) ⬇️
logging/telemetryspec/metric.go 47.87% <0.00%> (-34.05%) ⬇️
crypto/vrf.go 50.00% <0.00%> (-26.93%) ⬇️
rpcs/txSyncer.go 58.49% <0.00%> (-15.10%) ⬇️
data/transactions/signedtxn.go 14.81% <0.00%> (-14.82%) ⬇️
crypto/hashes.go 36.58% <0.00%> (-14.64%) ⬇️
crypto/util.go 41.17% <0.00%> (-11.77%) ⬇️
crypto/falconWrapper.go 65.38% <0.00%> (-11.54%) ⬇️
data/pools/transactionPool.go 38.51% <0.00%> (-11.27%) ⬇️
... and 33 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants