Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy templates: increase default npn number for mmnet-model #5178

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Mar 2, 2023

Summary

Default 5 npn appears too small to produce enough load for max TPS tests so set to 10

Test Plan

Manual test

onetechnical
onetechnical previously approved these changes Mar 2, 2023
algobarb
algobarb previously approved these changes Mar 2, 2023
@algobarb
Copy link
Contributor

algobarb commented Mar 2, 2023

actually, do we need to update the wallets in the default json to 10?

@algobarb algobarb self-requested a review March 2, 2023 20:25
Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw an extra comma but it's non-blocking.

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #5178 (84c5551) into master (c5936d2) will decrease coverage by 1.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5178      +/-   ##
==========================================
- Coverage   53.60%   52.11%   -1.50%     
==========================================
  Files         439      439              
  Lines       54944    54944              
==========================================
- Hits        29454    28634     -820     
- Misses      23205    23956     +751     
- Partials     2285     2354      +69     
Impacted Files Coverage Δ
agreement/agreementtest/keyManager.go 0.00% <0.00%> (-100.00%) ⬇️
agreement/agreementtest/simulate.go 0.00% <0.00%> (-85.53%) ⬇️
data/transactions/teal.go 0.00% <0.00%> (-84.00%) ⬇️
data/committee/sortition/sortition.go 23.52% <0.00%> (-58.83%) ⬇️
tools/network/resolveController.go 22.72% <0.00%> (-50.00%) ⬇️
network/netprio.go 41.30% <0.00%> (-28.27%) ⬇️
util/metrics/counter.go 64.51% <0.00%> (-25.81%) ⬇️
agreement/agreeInstall.go 75.00% <0.00%> (-25.00%) ⬇️
crypto/merkletrie/bitset.go 75.00% <0.00%> (-25.00%) ⬇️
data/transactions/logic/doc.go 42.30% <0.00%> (-19.24%) ⬇️
... and 59 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy merged commit 09a2c19 into algorand:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants