-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy templates: increase default npn number for mmnet-model #5178
deploy templates: increase default npn number for mmnet-model #5178
Conversation
actually, do we need to update the wallets in the default json to 10? |
test/testdata/deployednettemplates/generate-recipe/generate_network_tpl.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw an extra comma but it's non-blocking.
Codecov Report
@@ Coverage Diff @@
## master #5178 +/- ##
==========================================
- Coverage 53.60% 52.11% -1.50%
==========================================
Files 439 439
Lines 54944 54944
==========================================
- Hits 29454 28634 -820
- Misses 23205 23956 +751
- Partials 2285 2354 +69
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Summary
Default 5 npn appears too small to produce enough load for max TPS tests so set to 10
Test Plan
Manual test