Enhancement: minor change in agreement/type.go comment, numbers are not matching

[ahangsu]

Summary

Minor fix in agreement/type.go comment, the number seems to be not matching with the configuration.

[codecov]

Codecov Report

Merging #5186 (496d866) into master (4bbedc0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5186      +/-   ##
==========================================
+ Coverage   53.51%   53.52%   +0.01%     
==========================================
  Files         439      439              
  Lines       54985    54985              
==========================================
+ Hits        29423    29430       +7     
+ Misses      23271    23267       -4     
+ Partials     2291     2288       -3     

Impacted Files	Coverage Δ
agreement/types.go	87.93% <100.00%> (ø)

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[algorandskiy]

where 2500ms or 2000ms come from?

[ahangsu]

small lambda = 2000ms, while the comment said it is 2500ms, so it is wrong.

extra started from 2000 ms, so I need to fix the computation in comments too...

[cce]

It's here:

go-algorand/config/consensus.go

Lines 1298 to 1303 in c73ef66

	// Protocol holds the global configuration settings for the agreement protocol,
	// initialized with our current defaults. This is used across all nodes we create.
	var Protocol = Global{
	SmallLambda: 2000 * time.Millisecond,
	BigLambda: 15000 * time.Millisecond,
	}

[cce]

And here

go-algorand/agreement/types.go

Lines 28 to 30 in 7954f8e

	var deadlineTimeout = config.Protocol.BigLambda + config.Protocol.SmallLambda
	var partitionStep = next + 3
	var recoveryExtraTimeout = config.Protocol.SmallLambda