telemetry: fine-grained breakdown of AssembleBlockStats.StopReason #5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
approved these changes
Mar 10, 2023
Codecov Report
@@ Coverage Diff @@
## master #5191 +/- ##
==========================================
+ Coverage 52.69% 53.61% +0.92%
==========================================
Files 436 436
Lines 54876 54876
==========================================
+ Hits 28916 29422 +506
+ Misses 23612 23163 -449
+ Partials 2348 2291 -57
... and 71 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some of the AssembleBlockStats StopReason codes (especially AssembleBlockTimeout) are overloaded and catch multiple cases of block assembly completing. This splits out each case into a unique StopReason.
Test Plan
Telemetry only change, existing tests should pass.