Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algod: Remove unused 404 resp in simulate endpoint #5211

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

ahangsu
Copy link
Contributor

@ahangsu ahangsu commented Mar 16, 2023

Summary

As I was reading #5159, I noticed an addition of 404 response to /v2/transactions/simulate, while handler.go impl does not have notFound return.

So I remove the 404 response, as it is unused here.

Copy link
Contributor

@bbroder-algo bbroder-algo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this went away with the decision to remove the feature gate configuration parameter.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #5211 (f6be04a) into master (942eee1) will decrease coverage by 16.77%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5211       +/-   ##
===========================================
- Coverage   52.48%   35.71%   -16.77%     
===========================================
  Files         441      441               
  Lines       55098    55098               
===========================================
- Hits        28917    19679     -9238     
- Misses      23830    33353     +9523     
+ Partials     2351     2066      -285     

see 242 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants