-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goal: Introduce new command for simulate #5213
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5213 +/- ##
=======================================
Coverage 53.56% 53.57%
=======================================
Files 441 441
Lines 55098 55122 +24
=======================================
+ Hits 29515 29532 +17
- Misses 23298 23309 +11
+ Partials 2285 2281 -4
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
seems like the right way forward |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Minor testing comment: might be interesting to also test something with a failure message (e.g. overspend).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, and nice tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Introduce
goal clerk simulate
for simulation feature.Test Plan
e2e-sub test