tests: Change truncate to dd for mac amd tests #5256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
previously approved these changes
Apr 5, 2023
algorandskiy
reviewed
Apr 5, 2023
| @@ -22,7 +22,7 @@ CONST_FALSE="false" | |||
|
|
|||
| # First, try to send an extremely large "transaction" in the request body. | |||
| # This should fail with a 413 error. | |||
| truncate -s 11MB "${TEMPDIR}/toolarge.tx" | |||
| dd if=/dev/zero of=${TEMPDIR}/toolarge.tx bs=1M count=11 | |||
bbroder-algo
reviewed
Apr 5, 2023
| @@ -22,7 +22,7 @@ CONST_FALSE="false" | |||
|
|
|||
| # First, try to send an extremely large "transaction" in the request body. | |||
| # This should fail with a 413 error. | |||
| truncate -s 11MB "${TEMPDIR}/toolarge.tx" | |||
| dd if=/dev/zero of=${TEMPDIR}/toolarge.tx bs=11M count=1 | |||
There was a problem hiding this comment.
Suggested change
| dd if=/dev/zero of=${TEMPDIR}/toolarge.tx bs=11M count=1 | |
| dd if=/dev/zero of="${TEMPDIR}/toolarge.tx" bs=11M count=1 |
winder
approved these changes
Apr 5, 2023
Codecov Report
@@ Coverage Diff @@
## master #5256 +/- ##
==========================================
- Coverage 53.77% 51.73% -2.05%
==========================================
Files 450 450
Lines 56201 56201
==========================================
- Hits 30224 29073 -1151
- Misses 23627 24800 +1173
+ Partials 2350 2328 -22 see 91 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bbroder-algo
approved these changes
Apr 5, 2023
algorandskiy
approved these changes
Apr 5, 2023
This was referenced May 9, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes use of
truncatetoddwhen create large zero-ed files. This was due to a breaking nightly build inmac_amd64, since thetruncatecommand was not available there.Also adds all simulate test artifacts to the tempdir so they can be cleaned up at the end of the test. Locally checked that test files were being cleaned up by running
./test/scripts/e2e.sh