ledger: Check MaxAcctLookback in tracker. #5300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Warehime
approved these changes
Apr 12, 2023
algorandskiy
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
The condition looks good to me. Large MaxAcctLookback increase memory footprint a lot (like few GBs for 320 and full blocks). We also did not check performance impact - I suggest to run fast catchup on mainnet for 100K rounds and time it for MaxAcctLookback=4 (default) vs MaxAcctLookback=1000 to have better understanding of the behavior when we recommend someone to bump the value.
This was referenced May 9, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If
MaxAcctLookbackis set to a large number, the tracker fails during replay. The failure is an arbitrary "this doesn't seem quite right" sort of check. This change adds consideration for theMaxAcctLookbackvariable to allow a longer replay range.Another side effect of this change is that you can now fetch blocks from further than 1000 rounds ago. This has been requested many times.
Test Plan
Configured a node with
"MaxAcctLookback": 2048to reproduce the replay error. After updating the condition the replay error has gone away.