Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Fix ADMIN_TOKEN and add missing variables to echo statements. #5357

Merged
merged 2 commits into from
May 24, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented May 4, 2023

Summary

Add PROFILE to script output. This should help with debugging and parameter discoverability.

Test Plan

N/A

@winder winder requested review from excalq and algobarb May 4, 2023 13:30
@winder winder self-assigned this May 4, 2023
@winder winder marked this pull request as ready for review May 4, 2023 13:57
@winder winder requested a review from shiqizng May 4, 2023 13:57
@winder winder added the Bug-Fix label May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #5357 (6466743) into master (1634285) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5357      +/-   ##
==========================================
- Coverage   55.25%   55.23%   -0.02%     
==========================================
  Files         454      454              
  Lines       63723    63723              
==========================================
- Hits        35208    35200       -8     
- Misses      26122    26126       +4     
- Partials     2393     2397       +4     

see 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder changed the title docker: Add PROFILE to script output. docker: Fix ADMIN_TOKEN and add missing variables to echo statements. May 4, 2023
Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants