-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulate: Add State Change to Exec Trace #5659
Conversation
6f47cb8
to
ee27164
Compare
ee27164
to
02f4f2d
Compare
Codecov Report
@@ Coverage Diff @@
## master #5659 +/- ##
==========================================
- Coverage 55.18% 55.16% -0.03%
==========================================
Files 465 466 +1
Lines 64989 65075 +86
==========================================
+ Hits 35866 35896 +30
- Misses 26729 26784 +55
- Partials 2394 2395 +1
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9ccb6af
to
bf5afba
Compare
bf5afba
to
0ef35d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just naming thoughts so far.
96e02f9
to
c37c24a
Compare
c37c24a
to
59fefee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will take a closer look at testing tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good. I made some description language suggestions.
Guys, hold off a bit! Wait until #5658 merge in, for we need to extend some testcases from there |
please re-merge the master |
aeeb725
Summary
This PR implements #5015, which exposes app state (touches) changes in exec trace.
Test Plan
2 simulation eval test on boxes and app-local/global state.
1 rest client test on app-local/global state.