Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: regenerate api routes and resolve merge error in catchup #5821

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Nov 8, 2023

Summary

Somehow the latest merge caused codegen checker error, this regenerates stuff.

Regenerated with

touch daemon/algod/api/algod.oas2.json
make -C daemon/algod/api generate

Also there are two conflicting catchup PRs were merged causing error usage that was changed. Fixed as well.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #5821 (9871314) into master (7ebb9f4) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 67.64%.

@@           Coverage Diff           @@
##           master    #5821   +/-   ##
=======================================
  Coverage   55.60%   55.60%           
=======================================
  Files         475      475           
  Lines       66921    66946   +25     
=======================================
+ Hits        37209    37228   +19     
- Misses      27187    27198   +11     
+ Partials     2525     2520    -5     
Files Coverage Δ
catchup/peerSelector.go 98.71% <100.00%> (-1.29%) ⬇️
catchup/service.go 70.96% <50.00%> (+0.63%) ⬆️

... and 14 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

winder
winder previously approved these changes Nov 8, 2023
daemon/algod/api/algod.oas3.yml Show resolved Hide resolved
@algorandskiy algorandskiy changed the title daemon: regenarate routes daemon: regenerate routes Nov 8, 2023
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these changes look fine. One of them doesn't match the current description/title.

@algorandskiy algorandskiy changed the title daemon: regenerate routes build: regenerate api routes and resolve merge error in catchup Nov 8, 2023
@algorandskiy algorandskiy merged commit 3605084 into algorand:master Nov 8, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants