-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
algocfg: Add print option to algocfg. #5824
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5824 +/- ##
==========================================
+ Coverage 55.61% 55.71% +0.09%
==========================================
Files 475 475
Lines 66909 66916 +7
==========================================
+ Hits 37212 37280 +68
+ Misses 27182 27109 -73
- Partials 2515 2527 +12
... and 11 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and makes sense. I left a comment about a nit, but I don't consider that a blocker. If that error comes up in the future it can always be addressed then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think anything we are adding that is reusable across go-algorand should get basic testing, so in this case json.go could use a smoke test.
Summary
I frequently want to tell people a default configuration according to algocfg, but the only way to use it involves updating/creating a file in the data directory.
This PR adds a new
algocfg profile print <profile>
subcommand that writes configuration to stdout instead of to a regular file.Test Plan
Manual testing: